-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open .py
and .md
documents with the Notebook factory (Jupytext)
#6324
Comments
.py
and .md
documents with the Notebook factory (Jupytext)
@fcollonval I thought Which means there could be a check for this before redirecting to
|
Today it is not possible to coerce a factory to a existing file types. You can link a type and a factory either when defining the factory or the type. But if they have been defined as separated. This cannot be changed - in fact Jupytext is unique in that sense that it create an impossible contract on the frontend using a factory for an unsupported type. I'm reluctant to modify Jupyter core to support that corner case. Another possibility would be for Jupytext to override the default notebook factory plugin |
This should be feasible by hard-coding the settings plugin id the toolbar customization is read from to ensure it loads the core definition. |
@parmentelat just checking if the issue is now resolved with the latest Jupyter Notebook 7.0.3 release, as fixed by #6914 and linked issues and PRs? |
hi @jtpio yes the issue can be deemed fixed indeed, we've been using jupytext notebooks in the classroom since early september without a glitch, thanks ! |
That's great to hear! Thanks for the help, closing as fixed. |
Looking into this briefly, the trouble for jupytext are actually for file types already defined in core (like .py or .md). I was thinking to use the
Router
to deal with path like/notebooks/not/a-ipynb-file.ext
URL to redirect to the/edit/not/a-ipynb-file.ext?factory=Jupytext%20Notebook
if the extension is supported by Jupytext. What do you think @jtpio ?Originally posted by @fcollonval in #6315 (comment)
The text was updated successfully, but these errors were encountered: