Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix traitlets warning->error on 6.5.x #7051

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

minrk
Copy link
Member

@minrk minrk commented Sep 15, 2023

#6840 didn't get applied to 6.5.x, causing startup failure with recent traitlets 5.10

also fixes the typo that causes the import to always fail, which should only produce a warning, not an error.

closes #7048

it's jupyter_server.services.contents, not jupyter_server.contents.services
never part of the traitlets API
@minrk minrk added the bug label Sep 15, 2023
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch minrk/notebook/traitlets-warn-65x

@yuvanist
Copy link

@minrk FYI, This issue is present in v6.4.12 as well not just 6.5.x

@minrk
Copy link
Member Author

minrk commented Sep 18, 2023

@yuvanist you're right, there hasn't been a 6.4.13 release since the fix was merged.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit 566860b into jupyter:6.5.x Sep 19, 2023
3 checks passed
@blink1073
Copy link
Contributor

Released https://github.com/jupyter/notebook/releases/tag/v6.5.6 and https://github.com/jupyter/notebook/releases/tag/v6.4.13

@minrk
Copy link
Member Author

minrk commented Sep 19, 2023

Thanks @blink1073!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModuleNotFoundError: No module named 'jupyter_server.contents'
3 participants