-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.1.0a0+] Default file browser writes to a custom drive if installed #7210
Comments
This could be related to an upstream change w.r.t focus handling, as first clicking on the file browser widget and then creating the new directory seems to be fine: notebook-custom-drive-focus-issue.webm |
In the related command for creating a new directory, the file browser tracker const widget = tracker.currentWidget;
if (widget) {
return widget.createNewDirectory();
} |
Looking more into it, and setting a handler for the tracker const { tracker } = factory;
tracker.currentChanged.connect(() => {
console.log('current changed');
}); The underlying file browser tracker only seems to update its notebook-filebrowser-tracker-focus.webm |
This was mitigated in #7224. Moving to |
Testing with:
7.1.0a0
,7.1.0a1
or7.1.0a2
(or newer)The default file browser on the tree page tries to create files and directories in the installed drive, instead of the default file browser:
notebook-drive-issue.webm
Looking more closely, the model seems to be pointing to the custom drive (
GitHub:
)This is not an issue with
7.0.6
, so this is likely related to a change in the JupyterLab 4.1 pre-releases, or in some PRs targeting Notebook 7.1.Also this does not appear to be an issue in JupyterLab:
jupyterlab-create-new-folder-context-menu.webm
The text was updated successfully, but these errors were encountered: