Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting values file path directly #25

Open
yuvipanda opened this issue Nov 1, 2018 · 0 comments
Open

Allow setting values file path directly #25

yuvipanda opened this issue Nov 1, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@yuvipanda
Copy link
Contributor

In mybinder.org, we use chartpress to build images and set image tags in a deployment config file (such as config/staging.yaml or config/prod.yaml). Currently, values.yaml is hardcoded - would be nice to allow this to change.
yuvipanda added a commit to yuvipanda/mybinder.org-deploy that referenced this issue Nov 1, 2018
@yuvipanda
Push built images to prod GCR
3b2e751 
- We only push to prod, not staging, since chartpress isn't set up
  to do multiple pushes. jupyterhub/chartpress#25
  should help with that.
- Staging can read all prod images for now, to work around this.
- Create and use a new prod service acct that has image read / write perms.
This was referenced Nov 1, 2018
Merged
Open
@consideRatio consideRatio added the enhancement New feature or request label Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yuvipanda @consideRatio