Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup of Google Groups needs to account for pagination #767

Closed
jrdnbradford opened this issue Oct 6, 2024 · 0 comments · Fixed by #768
Closed

Lookup of Google Groups needs to account for pagination #767

jrdnbradford opened this issue Oct 6, 2024 · 0 comments · Fixed by #768

Comments

@jrdnbradford
Copy link
Contributor

Proposed change

Found while working on #763 and #764. This issue was present in the previous code as well as the updated call in #764.

Currently the API call to fetch Google Groups doesn't handle pagination. See the API docs for reference.

This has most likely not been reported yet because the default max number of groups retrieved is high enough that it hasn't caused a problem for users of Google Groups, although I cannot find what this number is (it is missing in the REST API docs and the Python docs).

Alternative options

We could ignore this problem since it apparently hasn't caused any issues, or we could add maxResults=200 to expand the number of potential groups retrieved. But if someone attempts to use the Google Oauthenticator and their Workspace users are members of hundreds of groups, there is potential for failed logins for both these alternative options.

Who would use this feature?

Those who use Google Groups for authentication.

(Optional): Suggest a solution

Add logic to handle pagination and retrieve all groups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant