You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Found while working on #763 and #764. This issue was present in the previous code as well as the updated call in #764.
Currently the API call to fetch Google Groups doesn't handle pagination. See the API docs for reference.
This has most likely not been reported yet because the default max number of groups retrieved is high enough that it hasn't caused a problem for users of Google Groups, although I cannot find what this number is (it is missing in the REST API docs and the Python docs).
Alternative options
We could ignore this problem since it apparently hasn't caused any issues, or we could add maxResults=200 to expand the number of potential groups retrieved. But if someone attempts to use the Google Oauthenticator and their Workspace users are members of hundreds of groups, there is potential for failed logins for both these alternative options.
Who would use this feature?
Those who use Google Groups for authentication.
(Optional): Suggest a solution
Add logic to handle pagination and retrieve all groups.
The text was updated successfully, but these errors were encountered:
Proposed change
Found while working on #763 and #764. This issue was present in the previous code as well as the updated call in #764.
Currently the API call to fetch Google Groups doesn't handle pagination. See the API docs for reference.
This has most likely not been reported yet because the default max number of groups retrieved is high enough that it hasn't caused a problem for users of Google Groups, although I cannot find what this number is (it is missing in the REST API docs and the Python docs).
Alternative options
We could ignore this problem since it apparently hasn't caused any issues, or we could add
maxResults=200
to expand the number of potential groups retrieved. But if someone attempts to use the Google Oauthenticator and their Workspace users are members of hundreds of groups, there is potential for failed logins for both these alternative options.Who would use this feature?
Those who use Google Groups for authentication.
(Optional): Suggest a solution
Add logic to handle pagination and retrieve all groups.
The text was updated successfully, but these errors were encountered: