[Google] Add include_nested_groups config
#763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
reviewed
Oct 1, 2024
There was a problem hiding this comment.
Thank you @jrdnbradford for working this!!! Let's go for a merge once the my final review comments are addressed, sorry for being indecisive about the naming!
Co-authored-by: Erik Sundell <[email protected]>
|
Awesome, thanks @consideRatio! Let me make these changes and test. I'll request another review when ready. Also, don't feel pressure to get this merged. No rush. |
|
Changes made. Thanks for your time and help on this, @consideRatio. |
consideRatio
changed the title
include_nested_groups config
consideRatio
approved these changes
Oct 1, 2024
|
Thank you for working this thoroughly @jrdnbradford!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First go at this, closes #762.
_fetch_user_groupsis now_fetch_member_groupssince it now checks user and group memberships in groups. I've updated some of the variable names fromuser_*tomember_*to reflect this. Whether nested groups are taken into account is set by a newallow_nested_groupsconfig option.The Google Python APIs for this are quite limited and this causes some slowness in the login experience for those who are members of a lot of groups.
I couldn't find where to update the docs for this authenticator. When I try to suggest an edit on that page it goes to
reference/api/gen/oauthenticator.google.rstwhich doesn't exist, I assume it's built elsewhere. If there's anywhere I can update this, let me know.I am also not entirely sure how to go about adding a mock test for this case.
I'd love feedback on how to make this better. Thanks! 🚀