Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3-dev] Dedicate one instance of LLM memory per chat #1147

Open
dlqqq opened this issue Dec 9, 2024 · 0 comments
Open

[v3-dev] Dedicate one instance of LLM memory per chat #1147

dlqqq opened this issue Dec 9, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@dlqqq
Copy link
Member

dlqqq commented Dec 9, 2024

Problem

In v3-dev, LLM memory is still a singleton that is shared across all chats. If you ask a question "What is 1+1" in foo.chat, you can still ask questions about your previous question in bar.chat.

Proposed Solution

  • Split LLM memory, i.e. dedicate one instance of LLM memory per chat
  • LLM memory should call a method on the YChat instance to fetch the most recent messages, instead of maintaining a list in-memory.
    • Add this method if it does not exist.
@dlqqq dlqqq added the enhancement New feature or request label Dec 9, 2024
@dlqqq dlqqq self-assigned this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant