You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@krassowski This seems like a separate issue, and thus I'd like it to be fixed in a separate PR if possible. Migrating the change from #465 into a separate branch and then rebasing #465 atop it might be a bit tricky, but it should be possible with an interactive rebase.
Both
@jupyter/collaboration
and@jupyterlab/collaboration
are defined as dependencies on the main branch:jupyter-ai/packages/jupyter-ai/package.json
Lines 63 to 68 in d6d34a5
But only the former is actually used:
jupyter-ai/packages/jupyter-ai/src/index.ts
Line 9 in d6d34a5
This leads to problems with tokens because two versions (v1 and v2) of
@lumino/coreutils
get pulled as can be seen in the lockfile:jupyter-ai/yarn.lock
Lines 3716 to 3730 in d6d34a5
This was introduced during upgrade to JupyterLab 4 (#296) which I think should have removed
@jupyterlab/collaboration
from the list of dependencies as it was never released with a support for v4 (https://www.npmjs.com/package/@jupyterlab/collaboration?activeTab=versions). Also that PR did this change:so it appears that not removing
@jupyterlab/collaboration
was an omission.This issue bitten me in #465; I will likely include a fix in there but let me know if you prefer a separate PR.
The text was updated successfully, but these errors were encountered: