Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stale @jupyterlab/collaboration dependency on main branch #480

Closed
krassowski opened this issue Nov 18, 2023 · 1 comment · Fixed by #489
Closed

Stale @jupyterlab/collaboration dependency on main branch #480

krassowski opened this issue Nov 18, 2023 · 1 comment · Fixed by #489
Labels
bug Something isn't working

Comments

@krassowski
Copy link
Member

Both @jupyter/collaboration and @jupyterlab/collaboration are defined as dependencies on the main branch:

"@jupyter/collaboration": "^1",
"@jupyterlab/application": "^4",
"@jupyterlab/cells": "^4",
"@jupyterlab/codeeditor": "^4",
"@jupyterlab/codemirror": "^4",
"@jupyterlab/collaboration": "^3",

But only the former is actually used:

import { IGlobalAwareness } from '@jupyter/collaboration';

This leads to problems with tokens because two versions (v1 and v2) of @lumino/coreutils get pulled as can be seen in the lockfile:

jupyter-ai/yarn.lock

Lines 3716 to 3730 in d6d34a5

"@lumino/coreutils@npm:^1.11.0 || ^2.0.0, @lumino/coreutils@npm:^1.11.0 || ^2.1.1, @lumino/coreutils@npm:^2.1.0, @lumino/coreutils@npm:^2.1.1":
version: 2.1.1
resolution: "@lumino/coreutils@npm:2.1.1"
checksum: dfdeb2b0282caae17b6c3edfebadf4ce7c75fc879fa60cacfef9b154412f4b35e4ffd95b1833b99d8dacb99aaaa04513570129ae2024c3f33e2677a01f0576ce
languageName: node
linkType: hard
"@lumino/coreutils@npm:^1.11.0, @lumino/coreutils@npm:^1.12.1":
version: 1.12.1
resolution: "@lumino/coreutils@npm:1.12.1"
peerDependencies:
crypto: 1.0.1
checksum: 55f1b87997f8dd0af28ff23c2d4b3aa252e515b9d3bc91b350a5c6c8526ceae61b14b55dc0d8d01691c69d42974b3d559f2b49bc7ced0f474b8f5dc52b3e83ed
languageName: node
linkType: hard

This was introduced during upgrade to JupyterLab 4 (#296) which I think should have removed @jupyterlab/collaboration from the list of dependencies as it was never released with a support for v4 (https://www.npmjs.com/package/@jupyterlab/collaboration?activeTab=versions). Also that PR did this change:

- import { IGlobalAwareness } from '@jupyterlab/collaboration';
+ import { IGlobalAwareness } from '@jupyter/collaboration';

so it appears that not removing @jupyterlab/collaboration was an omission.

This issue bitten me in #465; I will likely include a fix in there but let me know if you prefer a separate PR.

@krassowski krassowski added the bug Something isn't working label Nov 18, 2023
@krassowski krassowski mentioned this issue Nov 19, 2023
8 tasks
@dlqqq
Copy link
Member

dlqqq commented Nov 21, 2023

@krassowski This seems like a separate issue, and thus I'd like it to be fixed in a separate PR if possible. Migrating the change from #465 into a separate branch and then rebasing #465 atop it might be a bit tricky, but it should be possible with an interactive rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants