-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent experience with respect to non-installed third-party packages #840
Comments
Any thoughts or design (counter)proposals @dlqqq @srdas? While it is technically feasible to implement hot-installation without restarting the jupyter-server that would only work if the user is running in an environment which is not read-only (so requires a fallback path), hence for the first iteration I would suggest to only display information (ideally a ready-to-paste command) on what is needed. |
@krassowski Yes, I agree that this has been a major pain point for our users, and deserves more attention from us contributors. This was one of the things I wanted to fix right after Jupyter AI was presented at JupyterCon in May 2023, but other feature requests and fixes have repeatedly taken priority over this issue. I would like to work on this soon, but since resolving this issue would require a large time commitment, I need to get approval to work on this from my management chain. Let me offer some feedback here:
One concern I have is that it's unclear how the server extension would be able to know what models are not available due to the lack of a dependency package. We use the Entry Points API to load modules, which contain providers, which list available models under the This is a fundamental issue with our concept of "providers". Each provider needs to subclass a LangChain Here are the counter-proposals I've considered thus far (all of which would likely require a major release):
Let me know what you think! |
Yeah, I keep running into this issues on new installs as well. |
@krassowski Actually, there may be a way to support this in a minor release. @ellisonbg suggested that we could potentially show still show providers that are missing optional dependencies, without showing the full list of model IDs. These providers would still be listed in the model dropdown in the Settings UI, but when selected, they would prompt the user to install the optional dependency & restart the JupyterLab server, and not allow changes to be saved. |
One way to go about it would be using conditional imports in provider modules (if import fails we could use a shim which still allows to load the provider, but also sets some special attribute to distinguish it). |
Description
On a fresh install there are no Open AI models listed any more; this is similar for Anthropic. This tripped many users:
chatgpt
not available anymore in2.16.0
: _"Cannot determine model provider from model ID openai-chatgpt."_ #803Yet, the
Hugging Face Hub
is listed. When user selects it and attempts to use it it throws an error:Expected behavior
jupyter-ai
supports out of the box are shown or no models are shown by default or none of them are shown by default.Context
The text was updated successfully, but these errors were encountered: