Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable input placeholder text #15138

Closed
JasonWeill opened this issue Sep 19, 2023 · 7 comments · Fixed by #16713
Closed

Option to disable input placeholder text #15138

JasonWeill opened this issue Sep 19, 2023 · 7 comments · Fixed by #16713

Comments

@JasonWeill
Copy link
Contributor

Problem

#13797 added a placeholder text string for input() calls. Developers would like the option to disable this.

Proposed Solution

Add an option to disable the placeholder on inputs.

Additional context

See also jupyter/notebook#7063.

@JasonWeill JasonWeill added enhancement status:Needs Triage Applied to new issues that need triage and removed status:Needs Triage Applied to new issues that need triage labels Sep 19, 2023
@krassowski
Copy link
Member

It is a reasonable idea to have it as a setting, thanks for opening an issue over here @JasonWeill.

@gianoddone if you or someone else would like to contribute, you can follow #13944 which added inputHistoryScope setting as it touches the same files and we would need to thread it down similarly. In my opinion this should be opt-out setting (so we should continue to show the placeholder by default).

@gianoddone
Copy link

Thanks for checking it out. I have used notebook to make some interactive math games and enjoy the simplicity of input(). I guess there are other ways that afford more control with widgets, but I got stuck looking for a setting to disable the placeholder--which is impressive by the way--just not what I needed in this case.

Not sure I am qualified to contribute just yet, but certainly appreciate the work you all are doing on this project!

@gigoiy
Copy link

gigoiy commented Sep 25, 2023

I can contribute by adding this feature! I'll get working on this soon and open a PR.

@JasonWeill
Copy link
Contributor Author

@gigoiy Thank you! Please leave a comment on this issue, or chat with us on Discourse or Gitter, if you need help. You can find our community resources here: https://jupyter.org/community

@krassowski
Copy link
Member

For reference for anyone wishing to contribute, here is a related pull request which disabled placeholder for password prompts: #16128

@nitesh2920
Copy link

Is this still open? I would love to work on it. @krassowski @JasonWeill

@JasonWeill
Copy link
Contributor Author

@nitesh2920 Thank you for your interest! It looks like #16713 would fix this. I just pinged @krassowski to ask about merging this PR in for Lab 4.4.0, after 4.3.0 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants