Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat support notify the bot has been deleted or the bot delete contact #11

Open
su-chang opened this issue Jul 26, 2022 · 3 comments
Open

Comments

@su-chang
Copy link

su-chang commented Jul 26, 2022

Background

We need a new event for receive these notifications:

  1. the bot has been deleted by contact
  2. the bot delete contact by WeCom App in the phone

Due to we have friendship event already, I think it's better to reuse this event receive friendship delete event.

The only one thing we should do is that add a new type in FriendshipType:

export enum FriendshipType {
Unknown = 0,
Confirm,
Receive,
Verify,
}

Named the new FriendshipType type as Delete.

 export enum FriendshipType { 
   Unknown = 0, 
   Confirm, 
   Receive, 
   Verify, 
   Delete, 
 } 

Discuss

These two notifications should use the same type Deleted? Or add different type for them, e.g. Remove and Delete.

  • Remove: the bot has been deleted by contact
  • Delete: the bot delete contact by WeCom App in the phone
@su-chang
Copy link
Author

Vote for add two different FriendshipType: Remove and Delete

@su-chang
Copy link
Author

Conclusion

  • Removed: the bot has been removed by contact
  • Delete: the bot delete contact by WeCom App in the phone

@windmemory
Copy link
Member

It would be better to clearly separate the two concept with the types, so either Removed and Delete or Deleted and Delete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants