Feature/396 handle xlsx files #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. missing. Lint still failing due to cycle dependendies + type any warning.
fixed missing sheets on xlsx import of wb
|
@rhazn As discussed I added my example/test file as well as your requested changes from the previous PR. Please have a look. As discussed, either let me know if you have any further comments or just take over from here. The dataset I used is licensed with the CC BY-SA 4.0 license and can be found here. |
georg-schwarz
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
Reviewed the changes introduced by @rhazn - looked good to me.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New PR for #421 as original was closed by mistake.
Implements new XLSX-Interpreter and Sheet-Picker Block
PR closes #396.