Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(S)CSS files that are not referenced via styleUrls are not included in the dist output #257

Open
txinfo opened this issue Jan 5, 2018 · 1 comment

Comments

@txinfo
Copy link

txinfo commented Jan 5, 2018

Sometimes a library project may contain stylesheets like master theme files or default reference styles that can be imported by a consuming project. Currently the build process seems to only include styles that are explicitly used by components via the styleUrls property.

Gist with a sample patch to include this functionality: https://gist.github.com/txinfo/8e3665053c3c46206dfffbfcdbde581e

@txinfo txinfo changed the title (S)CSS files that are not referenced via styleUrls and inlined are not included in the dist output (S)CSS files that are not referenced via styleUrls are not included in the dist output Jan 5, 2018
@izifortune
Copy link
Collaborator

This seems like an nice feature but in case we include scss will be good to have them already compiled in css i believe since you are "publishing" your library. What do you think @jvandemo ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants