Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add testing for streamlit module #51

Open
jvivian opened this issue Mar 4, 2024 · 1 comment
Open

Add testing for streamlit module #51

jvivian opened this issue Mar 4, 2024 · 1 comment
Assignees
@jvivian
Labels
medium difficulty a bit more challenging than "good first issue" This Pleases The John Stuff John really wants (usually idiomatic refactoring) but isn't critical

Comments

@jvivian
Copy link
Owner

jvivian commented Mar 4, 2024

  • Move src from streamlit up one directory (?)
  • Add tests (use AppTest framework)

https://docs.streamlit.io/library/api-reference/app-testing
@jvivian jvivian self-assigned this Mar 4, 2024
@jvivian jvivian added good first issue Good for newcomers medium difficulty a bit more challenging than "good first issue" This Pleases The John Stuff John really wants (usually idiomatic refactoring) but isn't critical and removed good first issue Good for newcomers labels Mar 5, 2024
@JoshDFitzgerald
Copy link
Collaborator

I understand that there are non-UI components that is in our streamlit library, but are we wanting to get ~100% code coverage on our tests? Just wondering if it would be more efficient bypass testing for things like buttons, title values, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jvivian jvivian

Labels
medium difficulty a bit more challenging than "good first issue" This Pleases The John Stuff John really wants (usually idiomatic refactoring) but isn't critical
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jvivian @JoshDFitzgerald