Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jbang enable ap-loader? #6

Closed
maxandersen opened this issue Feb 14, 2023 · 2 comments
Closed

jbang enable ap-loader? #6

maxandersen opened this issue Feb 14, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@maxandersen
Copy link
Contributor

ap-loader is awesome and I realized I can do this:

jbang me.bechberger:ap-loader-all:LATEST

Allowing you to use ap-loader directly with no extra downloads (assuming you already have jbang)

without jbang it would be:

curl -Ls https://sh.jbang.dev | bash -s - me.bechberger:ap-loader-all:LATEST

In that spirit I was wondering if you would be up for adding a jvm-profiling-tools/jbang-catalog github repo or adding a jbang-catalog.json to this repo ?

it would allow to do:

jbang ap-loader@jvm-profiling-tools as a shorthand.

if inside this repo it would be jbang ap-loader@jvm-profiling-tools/ap-loader

I can make PR's for both approaches but would need jbang-catalog repo to exist first if going for that option.

Can also just make update to the readme using the GAV approach (jbang me.bechberger:ap-loader-all:LATEST)

WDYT?

@maxandersen
Copy link
Contributor Author

btw. due to #7 I suggest to use the github release URL instead then jbang https://github.com/jvm-profiling-tools/ap-loader/releases/latest/download/ap-loader-all.jar works.

I added ap-loader to https://github.com/maxandersen/jbang-catalog so you can give it a try:

jbang ap-loader@maxandersen for cli or jbang --javaagent=ap-loader@maxandersen=.... to load as agent.

This can be combined with anything jbang can run, i.e.

jbang --javaagent=ap-loader@maxandersen=start,event=cpu,file=profile.html quarkus@quarkusio

jbang --javaagent=ap-loader@maxandersen=start,event=cpu,file=profile.html scriptondisk.java

or ap-loader itself (except that fails because of multiple async-profilers collision)

jbang --javaagent=ap-loader@maxandersen=start,event=cpu,file=profile.html me.bechberger:ap-loader-all:LATEST

@parttimenerd
Copy link
Member

In that spirit I was wondering if you would be up for adding a jvm-profiling-tools/jbang-catalog github repo or adding a jbang-catalog.json to this repo ?

You could certainly create a PR to add this file (and write a notice in the README).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants