Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip default images from the config #5260

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

makhov
Copy link
Contributor

@makhov makhov commented Nov 15, 2024

Description

In case we have the following configuration, k0s will generate a dynamic config with all the default images. This breaks upgrades on air-gapped environments

apiVersion: k0s.k0sproject.io/v1beta1s
kind: ClusterConfig
spec:
  images:
    default_pull_policy: Never
  network:
    nodeLocalLoadBalancing:
      enabled: true
      type: EnvoyProxy

Fixes #5258

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@makhov makhov marked this pull request as ready for review November 15, 2024 11:48
@makhov makhov requested review from a team as code owners November 15, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates on complex airgapped controller+worker are broken in some cases
2 participants