Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow optional disabling of pvc deletion #664

Open
ericsmalling opened this issue Jun 3, 2024 · 3 comments
Open

Allow optional disabling of pvc deletion #664

ericsmalling opened this issue Jun 3, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@ericsmalling
Copy link

ericsmalling commented Jun 3, 2024

What is missing?

Add a boolean toggle to disable the automatic deletion of PVCs by the reconciler during datacenter deletion process.

Why is this needed?

My clients manually manage PVC reclamation in their clusters and if one of their end-users deletes a datacenter, they want to be able to retain the pvc or delete in on their own schedule.

┆Issue is synchronized with this Jira Story by Unito
┆Issue Number: CASS-6

@ericsmalling ericsmalling added the enhancement New feature or request label Jun 3, 2024
@burmanm
Copy link
Contributor

burmanm commented Jun 20, 2024

I'm not a fan of creating new boolean for this, but I'd be happy to accept a PR if it adds an annotation to the CassandraDatacenter to prevent these. We already have two similar ones, "cassandra.datastax.com/no-cleanup"and "cassandra.datastax.com/no-finalizer"

So something like no-pvc-deletion could be added to the CassandraDatacenter and check the existence of it before executing https://github.com/k8ssandra/cass-operator/blob/master/pkg/reconciliation/reconcile_datacenter.go#L91

@ericsmalling
Copy link
Author

The no-pvc-deletion CR option sounds like a good idea.

@ericsmalling
Copy link
Author

Returning from a break, will be working on this asap

@burmanm burmanm assigned burmanm and unassigned burmanm Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: No status
Development

No branches or pull requests

2 participants