Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the requeue delay when a Medusa reconcile errors out #1050

Closed
1 task
adejanovski opened this issue Sep 14, 2023 · 0 comments · Fixed by #1153
Closed
1 task

Remove the requeue delay when a Medusa reconcile errors out #1050

adejanovski opened this issue Sep 14, 2023 · 0 comments · Fixed by #1153
Assignees
@adejanovski
Labels
done Issues in the state 'done' refactoring

Comments

@adejanovski
Copy link
Contributor

The Medusa related controllers tend to specify the RequeueAfter value as reconcile result when an error is returned (like here).

This is redundant and misleading as reconcile errors will result in a requeue anyway.

We should clean up the code of the Medusa controllers to remove the RequeueAfter setting in failure cases.

Definition of Done
Preview Give feedback
@adejanovski adejanovski moved this to Ready in K8ssandra Sep 14, 2023
@adejanovski adejanovski added the ready Issues in the state 'ready' label Sep 14, 2023
@adejanovski adejanovski self-assigned this Jan 4, 2024
@adejanovski adejanovski moved this from Ready to In Progress in K8ssandra Jan 4, 2024
@adejanovski adejanovski added in-progress Issues in the state 'in-progress' and removed ready Issues in the state 'ready' labels Jan 4, 2024
@adejanovski adejanovski mentioned this issue Jan 4, 2024
Merged
5 tasks
@adejanovski adejanovski moved this from In Progress to Ready For Review in K8ssandra Jan 4, 2024
@adejanovski adejanovski added ready-for-review Issues in the state 'ready-for-review' and removed in-progress Issues in the state 'in-progress' labels Jan 4, 2024
@github-project-automation github-project-automation bot moved this from Ready For Review to Done in K8ssandra Jan 5, 2024
@adejanovski adejanovski added done Issues in the state 'done' and removed ready-for-review Issues in the state 'ready-for-review' labels Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adejanovski adejanovski

Labels
done Issues in the state 'done' refactoring
Projects
No open projects
K8ssandra
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unnecessary requeues k8ssandra/k8ssandra-operator
1 participant
@adejanovski