Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Central install dispatch #778

Open
kaihowl opened this issue Jun 4, 2024 · 0 comments
Open

Central install dispatch #778

kaihowl opened this issue Jun 4, 2024 · 0 comments

Comments

@kaihowl
Copy link
Owner

kaihowl commented Jun 4, 2024

Instead of repeating the same switch case over all install files:

  • Platform and architecture for binary installs
  • or platform for package manager installs

create a central config file. The format is tab separated.

For binary install the format is:

<name>\t<platform>\t<architecture>\tbinary\t<url>\t<checksum>

For package manager installs the format is:

<name>\t<platform>\t<architecture>\t<packagemanager>\t<arguments>

Replace all install invocation and switch cases with

dotinstall <name>

This will internally search for a line in the central config file that matches the name, platform, and architecture. If more than one line is matched, the install will abort.

Open questions:

  • How and if to handle different extraction processes for the installed binary files?
kaihowl added a commit that referenced this issue Nov 9, 2024
kaihowl added a commit that referenced this issue Nov 9, 2024
kaihowl added a commit that referenced this issue Nov 9, 2024
kaihowl added a commit that referenced this issue Nov 9, 2024
kaihowl added a commit that referenced this issue Nov 9, 2024
kaihowl added a commit that referenced this issue Nov 9, 2024
kaihowl added a commit that referenced this issue Nov 10, 2024
kaihowl added a commit that referenced this issue Nov 10, 2024
kaihowl added a commit that referenced this issue Nov 10, 2024
Fixes #792, #778

# Testing
- [x] centos final test (including test commit with remote gpg signing)
  - remote signing did not work -> separate issue
- [x] performance: No significant impact. macOS shows higher nvim load
times but this is in line with past noise before the change.

topic:nixpkgs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant