Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all types/@ember__* packages explicitly #146

Open
lolmaus opened this issue Jan 20, 2021 · 3 comments
Open

Add all types/@ember__* packages explicitly #146

lolmaus opened this issue Jan 20, 2021 · 3 comments

Comments

@lolmaus
Copy link
Contributor

lolmaus commented Jan 20, 2021

The @types/ember package contains them, but in order for automatic imports to work in VS Code, individual types/@ember__* packages must be explicitly listed in package.json.

https://www.typescriptlang.org/dt/search?search=@typesember

@simonihmig
Copy link
Member

As mentioned in the other PR, I am a bit worried having to do this everywhere. Do you have any other confirmations that this is really required for VSCode? (SO, Github issue etc.)

Maybe this gets fixed in VSCode itself eventually?

@lolmaus
Copy link
Contributor Author

lolmaus commented Jan 21, 2021

As mentioned in the other PR, I am a bit worried having to do this everywhere

I don't see an issue here. The boilerplate addon will do it automatically.


Do you have any other confirmations that this is really required for VSCode? (SO, Github issue etc.)

Nope.


Maybe this gets fixed in VSCode itself eventually?

I can try starting an issue. 🤷‍♂️

@simonihmig
Copy link
Member

I don't see an issue here. The boilerplate addon will do it automatically.

But what about future updates? Say @types/ember introduces a new types/@ember__foo package as a dependency:

  • when dependabot updates @types/ember, it does not know about adding types/@ember__foo
  • we could add types/@ember__foo to the boilerplate addon, but
    • would need to know it has been added
    • do the manual work in the boilerplate addon
    • do the manual work in all apps re-running the boilerplate blueprint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants