Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions based on the fse package #6

Open
avimallu opened this issue May 17, 2023 · 4 comments
Open

Suggestions based on the fse package #6

avimallu opened this issue May 17, 2023 · 4 comments

Comments

@avimallu
Copy link

avimallu commented May 17, 2023

Hi,

I'm excited to see how this package grows - if I may, I'd suggest a glimpse at the FSE package roadmap in oborchers/Fast_Sentence_Embeddings#49 for some additions to the TODO things on the README. If a solid Rust base is present for multiple extensions of SIF, it'll make a great base to be used via Python.

I can't wait for a Python binding based on a Rust implementation of SIF and its variants!

Cheers!

@kampersanda
Copy link
Owner

@avimallu

Thank you for your suggestion and information!

The roadmap will be beneficial in growing this library. I will utilize it for designing the API.

@avimallu
Copy link
Author

avimallu commented Jul 4, 2023

@kampersanda, great progress on the package! Are the plans to build Python bindings still intact?

@kampersanda
Copy link
Owner

@avimallu Yes. But, sif-embedding includes some dependencies to external Rust libraries (at the API level) and I am trying to figure out how to resolve this successfully.

@kampersanda
Copy link
Owner

I created the issue #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants