Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

black lines should be colorable #12

Open
japanoise opened this issue Sep 1, 2019 · 2 comments
Open

black lines should be colorable #12

japanoise opened this issue Sep 1, 2019 · 2 comments

Comments

@japanoise
Copy link

self explanatory. the cursor has a thin black line between the top and bottom square, and the tag bars have one at the top; the text areas have one on the left. this should either be colorable or follow the colors of the rest of the interface, because it really goes pete tong if you use a dark theme

@japanoise
Copy link
Author

Dear past me/other people that want the same thing:

The cursor can be fixed by the following patch to plan9port:

diff --git a/src/libframe/frinit.c b/src/libframe/frinit.c
index 90931f25..5e97ceb7 100644
--- a/src/libframe/frinit.c
+++ b/src/libframe/frinit.c
@@ -52,7 +52,7 @@ frinittick(Frame *f)
 	/* background color */
 	draw(f->tick, f->tick->r, f->cols[BACK], nil, ZP);
 	/* vertical line */
-	draw(f->tick, Rect(f->tickscale*(FRTICKW/2), 0, f->tickscale*(FRTICKW/2+1), ft->height), f->display->black, nil, ZP);
+	draw(f->tick, Rect(f->tickscale*(FRTICKW/2), 0, f->tickscale*(FRTICKW/2+1), ft->height), f->cols[TEXT], nil, ZP);
 	/* box on each end */
 	draw(f->tick, Rect(0, 0, f->tickscale*FRTICKW, f->tickscale*FRTICKW), f->cols[TEXT], nil, ZP);
 	draw(f->tick, Rect(0, ft->height-f->tickscale*FRTICKW, f->tickscale*FRTICKW, ft->height), f->cols[TEXT], nil, ZP);

Or conceivably you could manually patch the cursor (called "tick" in plan 9 jargon) after frinit in text.c in acme2k.

As for the tag bar etc. that's fixed by patches in forks. For instance my fork: https://github.com/japanoise/acme2k

@japanoise
Copy link
Author

9fans/plan9port#627

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant