Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nominate windsonsea to the global reviewers #589

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

XiShanYongYe-Chang
Copy link
Member

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Apr 10, 2024
@karmada-bot karmada-bot requested review from Arhell and pigletfly April 10, 2024 09:45
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 10, 2024
@XiShanYongYe-Chang
Copy link
Member Author

/cc @windsonsea @RainbowMango

@RainbowMango
Copy link
Member

/lgtm

@windsonsea has made a significant contribution, impressive!

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2024
@RainbowMango
Copy link
Member

/approve

/hold
for @windsonsea confirm. (Feel free to unhold )

@karmada-bot karmada-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 11, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2024
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@windsonsea
Copy link
Member

wow, thanks, I would like to help you to review more about docs and text. 😄

@XiShanYongYe-Chang
Copy link
Member Author

/hold cancel

@karmada-bot karmada-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 11, 2024
@karmada-bot karmada-bot merged commit e4d9a7f into karmada-io:main Apr 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants