Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spearman's correlation #21

Open
ysbioinfo opened this issue Jul 30, 2020 · 2 comments
Open

Add Spearman's correlation #21

ysbioinfo opened this issue Jul 30, 2020 · 2 comments

Comments

@ysbioinfo
Copy link

Hi,
First thanks a lot for developing such an awesome package! It gives me a lot of help!
I noticed that only pearson correlation is allowed now, is it possible for you to add spearman correlation in cor_test?

Thanks!

Yang

@karoliskoncevicius karoliskoncevicius changed the title Need spearman correlation in cor_test() Add Spearman's correlation Jul 30, 2020
@karoliskoncevicius
Copy link
Owner

Hello,

Glad to hear you like the package. When I developed it I was surprised I was the first to see the need for a general package with tests like that... So always good to see other people appreciate it too.

About Spearman correlation - it is possible to add it, but it takes a lot more time compared with Pearson's correlation. Plus it might not be as fast in the end, since it uses ranks which are harder to vectorise. Adding Spearman's correlation is on my mind, but cannot promise it will be added quickly. Will have a look this week and try to estimate how much time it would take.

@ysbioinfo
Copy link
Author

Thanks for the clarification about the difference between spearman and pearson. I don't know much about the underlying mechanism of vectorization but may you succeed and make matrixTests more powerful!
Thanks again.

Yang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants