Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcut in URL Preferences #18

Open
samo79 opened this issue May 5, 2020 · 8 comments
Open

Shortcut in URL Preferences #18

samo79 opened this issue May 5, 2020 · 8 comments

Comments

@samo79
Copy link

samo79 commented May 5, 2020

In the URL Preferences window, the shortcut in the string:

"Cookie Name Filter"

Doesn't work

@javierdlr
Copy link

Seems the problem is that the LabelObject and the StringObject aren't "linked"/binded (dunnot how to explain).

https://www.os4coding.net/forum/label-hotkey-not-working-some-string-gadgets

@samo79
Copy link
Author

samo79 commented May 19, 2020

Thanks to having look at :)
If it's a MUI issue eventually i can even open a ticket there

@javierdlr
Copy link

It's not a MUI issue, is how is coded/created such LabelObject+StringObjects in Odyssey.
It can be "fixed" and if you find/see other stringadgets that "need" it they can be changed to use "fixed" code.

@samo79
Copy link
Author

samo79 commented May 19, 2020

Ok understand
I checked the entire translation many time and i believe this specific string was the only one

@javierdlr
Copy link

Looking at the prefs GUI and other prefs/settings window, it looks that you're right.
Maybe just removing such shortcut is "clever" rather than searching for stringgadgets and see if they "need" a shortcut (and then modifying code to use "fixed" one).
Just to keep some consistency on prefs window.

@samo79
Copy link
Author

samo79 commented May 19, 2020

For my italian translatiln I've added shortcuts in pratically every area of the prefs and in some specific place when i consider they can be usefull.
Other area i leaved without, because they may conflict with the user typing..

Aniway I tried now to add shortcuts in a couple of checkboxes of the bookmark window:

Show in menu
Quick link

Then tested, but apparently they doesn't work ... probably also that two were created in the same "broken" method of the one in url preferences ?

@javierdlr
Copy link

Ok, let my ask kas1e is it's worth the efort to "update" such stringgadets (already had "fixed" code, just need to update in odyssey code)

@samo79
Copy link
Author

samo79 commented May 20, 2020

Ok meanwhile I rechecked again the entire catalog and can confirm that there are only that 3 checkboxes that might need this modification in order to support eventual user shortcuts

Cookie Name Filter (in url prefs window)
Show in menu (in bookmark window)
Quick link (in bookmark window)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants