Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC2: Lost ability to add an icon AmiDock on Iconify #4

Open
raziel- opened this issue Mar 15, 2020 · 13 comments
Open

RC2: Lost ability to add an icon AmiDock on Iconify #4

raziel- opened this issue Mar 15, 2020 · 13 comments

Comments

@raziel-
Copy link

raziel- commented Mar 15, 2020

See title.
RC1 and RC2 lost the ability to add an icon to AmiDock running apps.
The release on OS4Depot.net does it just fine.

And yes, the MUI setting to add an icon to AmiDock is set.

@kas1e
Copy link
Owner

kas1e commented Mar 15, 2020

How can I reproduce it step by step? I just never use amidock with oddysey for anything but as launcher panel.

@raziel-
Copy link
Author

raziel- commented Mar 15, 2020

  1. Open AmiDock (or rather right-click into the dock and choose "Edit")
    On the left side are your Docks, probably just one
  2. Add another one there and call it "ActiveApps" or something
  3. Now look at the bottom of the Edit window underneath "General"
    Place AppDockies in: (followed by a cycle gadget)
  4. Choose your new dock and SAVE

To test if it is working, start RuninUAE for example, or AmiUpdate (both place their dockies in there if iconified and if it was set in their settings).

Check with the release 1.23 from OS4Depot first to see that the icon will be placed there on iconification.
RC 1 and 2 won t, at least not for me

@kas1e
Copy link
Owner

kas1e commented Mar 15, 2020

Tested, the first time I tried it didn't work for me with RC2, then I tried one from os4depot: works. Then again tried RC2: and this time it works :)

Then I do clean reboot and run it RC2: works.

Something strange happens for sure, but can you try to reboot as well, and try R2 again?

@raziel-
Copy link
Author

raziel- commented Mar 15, 2020

Yep, it s my bookmarks file that causes it.

Sent to you in private

@raziel-
Copy link
Author

raziel- commented Mar 15, 2020

Bah, wrong item...

I have done dozens of reboots with no luck.

But i just tried with an install from ram: and that works, so itß s yet another probloem with an old setting or .db

@raziel-
Copy link
Author

raziel- commented Mar 16, 2020

Nope, here is the new step by step...

  1. Remove or rename bookmarks.html
  2. Start Odyssey
  3. Iconify Odyssey
    All is fine, Docky icon appears
  4. Close Odyssey
    A new empty bookmarks file will be created (with MorphOS in it's title)
  5. Start Odyssey again
  6. Iconofy Odyssey again
    No more Docky icon

@kas1e
Copy link
Owner

kas1e commented Mar 16, 2020

But that again not fresh install, but some older install you have before? Issues can be of any kind with new builds and old configs. We need something to reproduce just from fresh/clean unpack to ram:

I am sure there indeed some bug, just need to reproduce it somehow with a fresh unpack (so if it will be mui, it will be easy to track down to thore, if it will be odyssey, it will be easier to check wtf with prints and stuff)

@raziel-
Copy link
Author

raziel- commented Mar 16, 2020

NJope, that was a completely fresh and vanilla RC2 install.

I only added my bookmark file and poof went the weasel...

@kas1e
Copy link
Owner

kas1e commented Mar 16, 2020

So you added your bookmark (which may trash the memory then).. Uhm.. how to catch that damn bug..

@raziel-
Copy link
Author

raziel- commented Mar 16, 2020

I think i get it now.
It s no setting in conf, but a setting in envarc:mui

The first time i start Odyssey the old setting is read from ENVARC:.
Odyssey behaves normal (iconification dock icon created), but then, when i close Odyssey the néw setting is written to ENVARC: and that is where it breaks.
No need for my bookmarks file, a restart of Odyssey is all that it needed to make it behave wrong.
Something in the (MUI) settings code is flawed.

I need to check that further, but i lack the time right now, maybe later.

@kas1e
Copy link
Owner

kas1e commented Mar 16, 2020

Oh that good find, I will experiment with too.

@raziel-
Copy link
Author

raziel- commented Mar 24, 2020

Progress:
I found the guilty setting (at least one, maybe there are more, but i stopped looking for now).
Luckily it was the first settings page.

Steps to reproduce:

  1. PD Menu Settings/Preferences
    On the "General" page, set
  2. Start page to "http://kas1e.mikendezign.com/"
    or rather to everything else THAN "about:", "about:blank" or similar, pretty much everything out in the www
    NB: If you had a docky icon before you will still have one after the change and the save.and iconify.
    It's only after a quit and a new start of Odyssey that the bug kicks in (sneaky little bugger)
  3. Save
  4. Quit Odyssey
  5. Restart Odyssey
    From now on, no Docky icon will be added to AmiDock anymore.

Strange bug that is for sure :-/

@raziel-
Copy link
Author

raziel- commented May 28, 2020

RC7
This is rather flaky behaviour.

Once i start Odyssey and, without doing anything, iconify Odyssey, the icon will show up.
As soon as i surf to any website OR simply reload the startpage, the icon will never been seen again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants