Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve File Tree #6

Open
2 of 5 tasks
TheUltDev opened this issue Jun 8, 2023 · 5 comments
Open
2 of 5 tasks

Improve File Tree #6

TheUltDev opened this issue Jun 8, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@TheUltDev
Copy link
Contributor

TheUltDev commented Jun 8, 2023

  • Refactor WebContainer filesystem crawling (use chokidar?)
  • Fix visuals (top cutoff in PWA scenarios, spacing is off, etc.)
  • Add file icons (parse VSCode icon theme format)
  • Add handling of renaming files
  • Add handling of moving files
@TheUltDev TheUltDev added the enhancement New feature or request label Jun 8, 2023
@TheUltDev
Copy link
Contributor Author

Added Chokidar file watching (ce0d8f8). You can now see file changes in the console. This will be used to update the file tree in the future.

@FossPrime
Copy link
Collaborator

FossPrime commented Jun 8, 2023

Chokidar gives me nothing but nightmares... how does vite watch things?

@TheUltDev
Copy link
Contributor Author

TheUltDev commented Jun 8, 2023

Chokidar give me nothing but nightmares... how does vite watch things?

@FossPrime With native modules which WebContainers cannot use.

StackBlitz has indicated they will add a watch method to their FileSystem API, when they do add that I'll replace Chokidar. In the mean time that's really the only option...

@FossPrime
Copy link
Collaborator

FossPrime commented Jun 8, 2023

Vite uses chokidar as a fallback.

Screenshot_20230609-004341

@TheUltDev TheUltDev assigned TheUltDev and FossPrime and unassigned TheUltDev Jun 9, 2023
This was referenced Jun 14, 2023
TheUltDev pushed a commit that referenced this issue Jun 15, 2023
Fixes issue #6
@TheUltDev TheUltDev self-assigned this Jun 16, 2023
@FossPrime
Copy link
Collaborator

weird stylesheet issue on Chrome Version 114.0.5735.133 (Official Build) (64-bit)
Scrollbars weren't there before.

Might be a postCss issue as there are new features that should automatically disable css polyfills.

Screenshot from 2023-06-22 18-40-38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants