Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protecting from too big pull request (invalid source branch, master meged fork) #21

Open
ad-m opened this issue May 23, 2020 · 1 comment

Comments

@ad-m
Copy link

ad-m commented May 23, 2020

Hello,

In projects, it happens that someone pull request points to the wrong source branch eg.
apache/airflow#8968 . In this case, the proposed changes are huge. Often, the source branch is also not a branch from which pull requests can be expected.

While waiting for the changes to be merged, it happens that the developers merge the master to feature branch to be able to use feature branch directly (installation directly from Git). These pull requests cannot be implemented also.

What can we do about it to support a community that makes pull requests invalid?

Greetings,

@kaxil
Copy link
Owner

kaxil commented May 25, 2020

We have 2 options:

  1. Create a flag to allow adding branch names for which a project accepts a PR: If someone creates a PR to another target branch, the bot can comment and close the PR

  2. Delete any branches for example in this particular case, the branch was created by dependable which we don't plan to use in Airflow project.

WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants