Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Jacobian determinant for transformation should take absolute value #126

Closed
xuyuon opened this issue Aug 3, 2024 · 2 comments
Closed

The Jacobian determinant for transformation should take absolute value #126

xuyuon opened this issue Aug 3, 2024 · 2 comments
Assignees
@xuyuon

Comments

@xuyuon
Copy link
Contributor

xuyuon commented Aug 3, 2024

Currently, JIM computes the density change in the parameter space due to transformation by calculating the Jacobian determinant. The absolute value of the Jacobian determinant should be used; otherwise, feeding it into the calculation of the log Jacobian determinant may result in nan values.
@thomasckng
Copy link
Collaborator

Mentioned and fixed in #133

@xuyuon
Copy link
Contributor Author

xuyuon commented Aug 21, 2024

The fix is moved to #137

@xuyuon xuyuon closed this as completed Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xuyuon xuyuon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

126-the-jacobian-determinant-for-transformation-should-take-absolute-value kazewong/jim
2 participants
@thomasckng @xuyuon