-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Balloon is appearing in all aria-label tags #119
Comments
This is causing problems also with DataTables because they used |
A dedicated attribute like content: var(attr(data-baloon-text), attr(aria-label)); |
The issue here is that a custom attribute would harm accessibility as discussed in #19.
@JoelNieto that code snippet you linked has the sole purpose of enabling tooltips even when not using |
Ideally, I think the user should be able to choose if they need accessibility ( |
I do have a working branch with working with a Ultimately, it can only be solved by switching to a dedicated data-attribute. Users concerned with accessibilty have to manually add |
Another solution can be forcing the use of So this would not show a tooltip: <button aria-label="My Text Here!">No tooltip!</button> While this would trigger Balloon.css and show the tooltip: <button aria-label="My Text Here!" data-balloon-pos="up">Yay, tooltip!</button> This way we prevent all |
That would be an option yes, assuming the user is in control of all tags that should show tooltips. Would be a breaking change thought, so be sure to bump the major version for this :) |
Hello, is there a workaround to this issue? I used balloon.css for a widget and when I integrated it in our site tooltips start appearing all around. |
Just pushed Now Balloon.css only activates when elements have both |
I'm using the CDN version and the tooltip isn't working well. It appears in all elements with aria-label tags.
Ironically, it doesn't show with those with data-balloon-pos tags.
This is your css code, why is this?
[aria-label]:not([data-balloon-pos]):before { bottom: 100%; left: 50%; transform: translate(-50%, var(--balloon-move)); transform-origin: top; }
The text was updated successfully, but these errors were encountered: