Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation for tooltips that have data-balloon-visible #136

Open
ghost opened this issue Mar 28, 2020 · 5 comments
Open

Animation for tooltips that have data-balloon-visible #136

ghost opened this issue Mar 28, 2020 · 5 comments

Comments

@ghost
Copy link

ghost commented Mar 28, 2020

In one of my recents projects I used data-balloon-visible attribute through javascript for alert the user if there is any kinda of error on the form's inputs.
I noticed that when the tooltip appear, there isn't any animation at all.

Step to reproduce:

Simply try to use a balloon tooltip with an data-baloon-visible setted through javascript.

Expected Behavior

The tooltip came up with an animation

Real Behavior

There isn't any animation at all

@moeenio
Copy link
Contributor

moeenio commented Apr 16, 2020

I can't reproduce, are you sure you're not using the data-balloon-bluntattribute?

@ghost
Copy link
Author

ghost commented Apr 17, 2020

Ok,
I did some research and testing, link here.
We have the problem only when we set the aria-label through js, otherwise all work fine.

@moeenio
Copy link
Contributor

moeenio commented Apr 17, 2020

If you wanna contribute, I think you should look here.

@ghost
Copy link
Author

ghost commented Apr 18, 2020

here were the tooltip blow up?

&:hover, &[data-balloon-visible] {

Also, if you are interested I did some other tests (link here), if you set the data-balloon-visible after aria-label all work well. Interesting behavior.

@moeenio
Copy link
Contributor

moeenio commented Apr 18, 2020

Yes, it's this part of the code that makes the tooltip show up. This behaviour is justified because it's the addition of the data-balloon-visible attribute that triggers the animation, that's the part of the code I pointed at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant