Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events for creating FTA node are fetched incorrectly #350

Closed
blcham opened this issue Jun 3, 2024 · 5 comments
Closed

Events for creating FTA node are fetched incorrectly #350

blcham opened this issue Jun 3, 2024 · 5 comments
Assignees

Comments

@blcham
Copy link
Contributor

blcham commented Jun 3, 2024

When fetching Events to create a root node or any other FTA node, we use the wrong API.

It seems that faultTrees/$ftaTree/reusableEvents is used but @kostobog mentioned that different API should be used (something like /all-fault-events/$systemFragment)

Motivation here is to have all relevant events -- we want to include also SNS based events so we would be able to create SNS node. Of course for root FTA node we do not want to choose from SNS-based events.

@blcham
Copy link
Contributor Author

blcham commented Jun 3, 2024

@kostobog please fix/add description above.

@blcham blcham self-assigned this Jun 3, 2024
@blcham
Copy link
Contributor Author

blcham commented Jun 3, 2024

FYI @LaChope

@LaChope
Copy link
Collaborator

LaChope commented Jun 3, 2024

@blcham If you want I can do this, I know where to update the API, just need to make sure that /all-fault-events/$systemFragment is the correct one.

@blcham blcham assigned LaChope and unassigned blcham Jun 4, 2024
@blcham
Copy link
Contributor Author

blcham commented Jun 4, 2024

  • we need IRI of System instead of name (need BK to fix on backend first)

@LaChope
Copy link
Collaborator

LaChope commented Jun 5, 2024

Closing as solved by #355.

@LaChope LaChope closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants