Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI Issues #152

Merged
merged 6 commits into from
Feb 1, 2024
Merged

Fix UI Issues #152

merged 6 commits into from
Feb 1, 2024

Conversation

kostobog
Copy link
Collaborator

…empty in compactAndResolveReferencesAsArray

- revert ad-hoc fix introduced in #125
- fix style of labels of comboboxes event and gate type
- rename name field to "fault-event-name" to remove missing autocomplete browser warning.
@blcham blcham self-requested a review January 25, 2024 13:20
Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but make sure that you read & resolve my comment.

@kostobog kostobog requested a review from blcham February 1, 2024 13:35
@blcham blcham merged commit 99de50f into main Feb 1, 2024
1 check passed
@blcham
Copy link
Contributor

blcham commented Feb 1, 2024

@kostobog merging

@blcham blcham deleted the fix/fixl-ui-issues branch February 8, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants