Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hints for fault event properties in fault event form FaultEventMenu #612

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

kostobog
Copy link
Collaborator

@blcham
Fix #227

  • rewrite calculated and required failure rate components in FaultEventMenu
  • rewrite HintText fixing styles

@kostobog kostobog requested a review from blcham September 30, 2024 11:42
Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although it would be nice to see how it behaves when e.g. out of sync

@blcham
Copy link
Contributor

blcham commented Sep 30, 2024

@kostobog mentioned that it should not be merged yet

@blcham blcham self-requested a review September 30, 2024 14:33
@kostobog kostobog force-pushed the fix/fta-fmea-ui-227-RE-and-hints-to-event-properties branch from dd0ad63 to a9a891c Compare September 30, 2024 14:39
@kostobog
Copy link
Collaborator Author

@blcham
Bug fixed.
PR can be merged

…enu)

- rewrite calculated and required failure rate components in FaultEventMenu
- rewrite HintText fixing styles
@blcham blcham force-pushed the fix/fta-fmea-ui-227-RE-and-hints-to-event-properties branch from a9a891c to db73b68 Compare October 2, 2024 13:41
@blcham blcham merged commit de3e56c into main Oct 3, 2024
1 check passed
@blcham blcham deleted the fix/fta-fmea-ui-227-RE-and-hints-to-event-properties branch October 3, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement hints for FTA node properties
2 participants