Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement #520] Change record filtering #572

Merged
merged 11 commits into from
Nov 25, 2024
Merged

[Enhancement #520] Change record filtering #572

merged 11 commits into from
Nov 25, 2024

Conversation

lukaskabc
Copy link
Collaborator

resolves #520

Implements UI for filtering the term/vocabulary change history and activity tab in the vocabulary details.

lukaskabc and others added 7 commits November 4, 2024 09:24
@lukaskabc
[Enhancement kbss-cvut#520] Vocabulary activity term changes filter
f3ebbf4 
A design of filter inputs for term change records in vocabulary activity tab.
@lukaskabc
[Enhancement kbss-cvut#520] Vocabulary activity term changes filter b…
fa1b65e 
…ackend requests

Removed time range input and implemented requesting data from BE using filter parameters.
@lukaskabc
[Enhancement kbss-cvut#520] Fix vocabulary content history not showin…
670f032 
…g pagination in activity tab when no records are available
@lukaskabc
[Enhancement kbss-cvut#520] Move shrinkFullIri to Utils
6f81543 
Moving shrinkFullIri to Utils allows consistent IRI shrinking outside the AssetLabel component.
@lukaskabc
[Enhancement kbss-cvut#520] Optimizing term labels in vocabulary cont…
8ff0138 
…ent history.

When DeleteRecord is loaded by FE, the label of deleted term is cached allowing to display it instead of IRI. When the label is not available, the IRI will be shrunk.
@lukaskabc
[Enhancement kbss-cvut#520] Add change history filtering for term and…
f37b2ff 
… vocabulary details.
@lukaskabc
[Ref] Cleanup code, remove duplicated comment from merge, eliminate a…
d0cfe17 
…lways true if statement
@lukaskabc lukaskabc requested a review from ledsoft November 15, 2024 10:37
ledsoft
ledsoft reviewed Nov 17, 2024
View reviewed changes
Copy link
Contributor

@ledsoft ledsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested functionality yet, but code-wise looks good to me.

ledsoft
ledsoft approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@ledsoft ledsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I was thinking about adding a reset filters button, but it would probably be quite difficult to add it to the UI. Let's keep it as is and if users want the reset button, we can add it later.

@ledsoft ledsoft linked an issue Nov 25, 2024 that may be closed by this pull request
Filtrování v historii změn #520
Closed
@ledsoft ledsoft merged commit 8ce480f into kbss-cvut:development Nov 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ledsoft ledsoft ledsoft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filtrování v historii změn
2 participants
@lukaskabc @ledsoft