-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebSockets #290
Merged
ledsoft
merged 12 commits into
kbss-cvut:development
from
lukaskabc:lukaskabc/Performance-285-websocket
Sep 3, 2024
Merged
WebSockets #290
ledsoft
merged 12 commits into
kbss-cvut:development
from
lukaskabc:lukaskabc/Performance-285-websocket
Sep 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ledsoft
requested changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor questions/suggestions
src/main/java/cz/cvut/kbss/termit/websocket/handler/WebSocketExceptionHandler.java
Show resolved
Hide resolved
ledsoft
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of WebSockets on HTTP(S) endpoint
/termit/ws
using STOMP protocol.WebSockets will be used in future PR addressing application performance (dev branch).
Authentication
WebSocket API in browsers does not allow setting custom headers for WS handshake (HTTP request for protocol upgrade),
which leaves us with three options for how to implement authentication using the JWT token:
Currently implemented as option 3, which is most reliable.
This means any WebSocket connection is accepted, and the client has limited time (15s) to send a STOMP CONNECT message with a valid JWT token. Otherwise, the connection is closed.
Changes
/vocabularies/{localName}/validate
replaced with matching ws endpointfindTermOccurrencesSetsFoundOccurrencesAsApprovedWhenCorrespondingExistingOccurrenceWasApproved
, which is failing on Windows, until the issue is resolvedTests
Prepared two test runners for WebSocket testing.
BaseWebSocketIntegrationTestRunner
, which starts the whole application context with an active web socket endpoint and establishes an actual web socket connection to the application. Currently used for WebSocket security test.BaseWebSocketControllerTestRunner
is used to test WebSocket controllers using mocked API.Required changes (TODO)