[Enhancement kbss-cvut/termit-ui#520] Change record filtering #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry detailed endpoint allowing result filtering.
…history query Query filters were using wrong variables, and removed unnecessary optional block.
…d vocabulary content detailed history endpoint
…ring vocabulary content changes by change type.
…ocabulary content endpoint return results when no filter is specified.
…on to ChangeRecordDao
…ulary & term history endpoints
…yId to return optional URI instead of throwing when term is not found (not in a vocabulary).
… VocabularyDaoTest to ChangeRecordDaoTest.
…ords to change context
… interface and add documentation.
ledsoft
requested changes
Nov 17, 2024
src/main/java/cz/cvut/kbss/termit/rest/VocabularyController.java
Outdated
Show resolved
Hide resolved
src/test/java/cz/cvut/kbss/termit/persistence/dao/changetracking/ChangeRecordDaoTest.java
Outdated
Show resolved
Hide resolved
…on in TermController & add constructors for ChangeRecordFilterDto
…s with Utils#timestamp
lukaskabc
force-pushed
the
lukaskabc/Enhancement-520
branch
from
736dc83 to
ab07485
Compare
# Conflicts: # src/main/java/cz/cvut/kbss/termit/persistence/dao/VocabularyDao.java # src/test/java/cz/cvut/kbss/termit/persistence/dao/VocabularyDaoTest.java # src/test/java/cz/cvut/kbss/termit/rest/VocabularyControllerTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves kbss-cvut/termit-ui#520
Implements filtering in ChangeRecordDao.
Several tests required modification because change records were stored in the vocabulary context instead of the change context.