Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: doc gen: display attributes in table #174

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

amyXia1994
Copy link
Contributor

@amyXia1994 amyXia1994 commented Oct 27, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

close #166

2. What is the scope of this PR (e.g. component or file name):

enhance: doc gen: display attributes in table

the file generated can be seen here:
https://github.com/amyXia1994/kcl-go/blob/enhance/doc-gen-attr-table/pkg/tools/gen/testdata/doc/pkg/md/main.md

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6664464256

  • 10 of 11 (90.91%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 65.616%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/tools/gen/genopenapi.go 8 9 88.89%
Files with Coverage Reduction New Missed Lines %
pkg/tools/gen/genopenapi.go 1 89.2%
Totals Coverage Status
Change from base Build 6664117545: -0.02%
Covered Lines: 2622
Relevant Lines: 3996

💛 - Coveralls

@amyXia1994 amyXia1994 force-pushed the enhance/doc-gen-attr-table branch 2 times, most recently from 5043b27 to 7fa52f8 Compare October 27, 2023 09:01
@amyXia1994 amyXia1994 force-pushed the enhance/doc-gen-attr-table branch from 7fa52f8 to 0b60828 Compare October 27, 2023 09:14
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 1f58d20 into kcl-lang:main Oct 27, 2023
6 of 7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants