-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support more keywords and improve conversion results for complex json schema #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jakezhu9 <[email protected]>
Signed-off-by: jakezhu9 <[email protected]>
Signed-off-by: jakezhu9 <[email protected]>
Signed-off-by: jakezhu9 <[email protected]>
Signed-off-by: jakezhu9 <[email protected]>
Peefy
reviewed
Jan 15, 2024
Peefy
reviewed
Jan 15, 2024
Signed-off-by: jakezhu9 <[email protected]>
Pull Request Test Coverage Report for Build 7530613143
💛 - Coveralls |
Peefy
reviewed
Jan 15, 2024
pkg/tools/gen/testdata/jsonschema/unsupport-multi-pattern-props/expect.k
Outdated
Show resolved
Hide resolved
Signed-off-by: jakezhu9 <[email protected]>
Peefy
reviewed
Jan 15, 2024
pkg/tools/gen/testdata/jsonschema/unsupport-multi-pattern-props/expect.k
Show resolved
Hide resolved
Signed-off-by: jakezhu9 <[email protected]>
Good Job! LGTM! |
Peefy
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
fix #200
2. What is the scope of this PR (e.g. component or file name):
pkg/tools/gen
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
Support oneOf, allOf and patternProperties keywords, improve conversion results for $ref and so on. Now we shuold get a better result when importing from complex json schema.
I try use it to convert the josn schema of github workflow (
pkg/tools/gen/testdata/jsonschema/complex-workflow/expect.k
), and use the result to check a workflow (pkg/tools/gen/testdata/yaml/workflow/expect.k
). After fixing some attribute name with-
(working-directory
->working_directory
,runs-on
->runs_on
), everything works fine!Of course, the processing of some keywords (such as allOf) is not perfect yet, and we can improve it in the future.
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: