-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide Quick fixes for Compile errors #1359
Provide Quick fixes for Compile errors #1359
Conversation
Signed-off-by: Shashank Mittal <[email protected]>
@Peefy Please review. Will be adding more fixes to this PR. |
Signed-off-by: Shashank Mittal <[email protected]>
Pull Request Test Coverage Report for Build 9236082833Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
I've merge this PR. There are still some issues: The first one is
will be fixed as
instead of removing the dup keyworld argument.
The second one is
will be fixed as
instead of
The third one is f = lambda x: int {
x
}
a = f(xx=1) will be fixed as
instead of f = lambda x: int {
x
}
a = f(x = 1) |
Signed-off-by: Shashank Mittal <[email protected]>
* some more quick fixes Signed-off-by: Shashank Mittal <[email protected]> * fix Signed-off-by: Shashank Mittal <[email protected]> * more fixes Signed-off-by: Shashank Mittal <[email protected]> * fmt Signed-off-by: Shashank Mittal <[email protected]> * grammar test fixed Signed-off-by: Shashank Mittal <[email protected]> * test fix Signed-off-by: Shashank Mittal <[email protected]> * fixes from #1359 Signed-off-by: Shashank Mittal <[email protected]> * fmt Signed-off-by: Shashank Mittal <[email protected]> --------- Signed-off-by: Shashank Mittal <[email protected]>
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
kclvm/sema/src/resolver/arg.rs
kclvm/tools/src/LSP/src/quick_fix.rs
kclvm/tools/src/LSP/src/to_lsp.rs
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
Screen.Recording.2024-05-25.at.12.53.21.PM.mov
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
Tests have not been written yet.
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: