Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unification stmt override #1435

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jun 24, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • fix: unification stmt override

@Peefy Peefy requested a review from zong-zhe June 24, 2024 11:52
@Peefy Peefy added api Issues or PRs related to kcl rust native APIs and multi-lang APIs tool Issues or PRs related to kcl tools inlucding format, lint, validation, document tools, etc. labels Jun 24, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jun 24, 2024

Pull Request Test Coverage Report for Build 9644779698

Details

  • 13 of 13 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 71.334%

Totals Coverage Status
Change from base Build 9633452432: 0.08%
Covered Lines: 55684
Relevant Lines: 78061

💛 - Coveralls

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 82bff23 into kcl-lang:main Jun 25, 2024
10 of 11 checks passed
@Peefy Peefy deleted the fix-unification-stmt-override branch June 25, 2024 03:42
@coveralls
Copy link
Collaborator

coveralls commented Jun 25, 2024

Pull Request Test Coverage Report for Build 9644779698

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 13 of 13 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 71.334%

Totals Coverage Status
Change from base Build 9633452432: 0.08%
Covered Lines: 55684
Relevant Lines: 78061

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issues or PRs related to kcl rust native APIs and multi-lang APIs tool Issues or PRs related to kcl tools inlucding format, lint, validation, document tools, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants