feat: add chars method for builtin str #1793
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jellllly420
force-pushed
the
feat/str-chars
branch
from
4652478 to
1ff703c
Compare
|
Some lsp test failed about str std method. just re-run and update *.snap file |
|
cc @zong-zhe |
jellllly420
force-pushed
the
feat/str-chars
branch
from
1ff703c to
737ae01
Compare
Signed-off-by: Zejun Zhao <[email protected]>
jellllly420
force-pushed
the
feat/str-chars
branch
from
737ae01 to
3fe5aa1
Compare
He1pa
reviewed
Dec 19, 2024
| @@ -17,6 +17,11 @@ def checkequal(self, result, obj, methodname, *args, **kwargs): | |||
| realresult = dylib.Invoke(f"str.{methodname}", obj, *args, **kwargs) | |||
| self.assertEqual(result, realresult) | |||
|
|
|||
| def test_chars(self): | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
kclvm/runtime/src/
kclvm/runtime/src/value/
kclvm/runtime/src/builtin/
kclvm/tests/test_units/runtime/str/
test/grammar/builtins/str/
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
This PR adds a
charsmethod for builtin str to return a list of the characters in the string.4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
Runtime test: kclvm/tests/test_units/runtime/str/
Grammar test: test/grammar/builtins/str/