Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is not check for whether scaletargetref exists in webhook for scaleobject #6354

Open
ctccxxd opened this issue Nov 21, 2024 · 0 comments
Open

There is not check for whether scaletargetref exists in webhook for scaleobject #6354

ctccxxd opened this issue Nov 21, 2024 · 0 comments
Labels
feature-request All issues for new features that have not been committed to needs-discussion

Comments

@ctccxxd
Copy link

ctccxxd commented Nov 21, 2024

Proposal

To check scaletargetref whether exists in scaleobject in webhook avoiding misconfiguration.

Use-Case

When users config a scaleobject, if the related scaletargetref is not found, currently webhook validate it.

Is this a feature you are interested in implementing yourself?

Yes

Anything else?

#6350 This is my code to solving this issue, welcome to review.
@ctccxxd ctccxxd added feature-request All issues for new features that have not been committed to needs-discussion labels Nov 21, 2024
@ctccxxd ctccxxd changed the title Ther is not check for whether scaletargetref exists in webhook for scaleobject There is not check for whether scaletargetref exists in webhook for scaleobject Nov 21, 2024
@ctccxxd ctccxxd mentioned this issue Nov 21, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request All issues for new features that have not been committed to needs-discussion
Projects
Roadmap - KEDA Core
Status: To Triage
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ctccxxd