Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

bug: github workflow Run rpc tests/rpc-tests cannot get InvokeTransactionReceipt #1557

Closed
fishseabowl opened this issue Apr 8, 2024 · 4 comments
Labels
bug Something isn't working stale

Comments

@fishseabowl
Copy link
Contributor

Bug Report

Madara version:

v.0.7.0

Current behavior:

In the PR #1526 , github workflow Run rpc tests/rpc-tests, the test case starknet-rpc-test::tarknet_estimate_fee::work_ok cannot get InvokeTransactionReceipt, but locally, the test case is ok.

Expected behavior:

The function JsonRpcClient.get_transaction_receipt can return InvokeTransactionReceipt

Steps to reproduce:

github workflow Run rpc tests/rpc-tests

Related code:

loop {
        let invoke_tx_receipt = rpc.get_transaction_receipt(invoke_transaction_result.transaction_hash).await?;

        match invoke_tx_receipt {
            MaybePendingTransactionReceipt::Receipt(TransactionReceipt::Invoke(receipt)) => {
                assert_eq!(FieldElement::from(estimates[0].overall_fee), receipt.actual_fee);
                break; // Break the loop if receipt is received
            }

            MaybePendingTransactionReceipt::PendingReceipt(PendingTransactionReceipt::Invoke(_)) => {
                time::sleep(Duration::from_secs(SLEEP_DURATION)).await;
            }

            _ => {
                panic!("expected invoke transaction receipt");
            }
        }
    }

Other information:

@fishseabowl fishseabowl added the bug Something isn't working label Apr 8, 2024
@tdelabro
Copy link
Collaborator

tdelabro commented May 6, 2024

@fishseabowl I'm not sure to understand what is the problem here?
And is it still there in the latest state of the codebase?

Copy link

github-actions bot commented Jun 6, 2024

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍
Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Jun 6, 2024
@tdelabro
Copy link
Collaborator

tdelabro commented Jun 6, 2024

@fishseabowl is it still a thing?

@fishseabowl
Copy link
Contributor Author

@tdelabro I think this issue has been resolved in PR #1601

@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

2 participants