Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: reduce memory consumption and dockerfile size #2578

Merged
merged 15 commits into from
Nov 25, 2024
Merged

chore: reduce memory consumption and dockerfile size #2578

merged 15 commits into from
Nov 25, 2024

Conversation

talboren
Copy link
Member

@talboren talboren commented Nov 21, 2024 •
edited
Loading

close #2605

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Nov 21, 2024
@vercel Vercel
Copy link

vercel bot commented Nov 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 8:57am

@codecov Codecov
Copy link

codecov bot commented Nov 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 36.36364% with 21 lines in your changes missing coverage. Please review.

Project coverage is 70.88%. Comparing base (892a79e) to head (35cd418).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
keep/api/core/db.py 14.28% 18 Missing ⚠️
keep/identitymanager/identitymanagerfactory.py 50.00% 2 Missing ⚠️
keep/api/utils/import_ee.py 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2578      +/-   ##
==========================================
+ Coverage   69.63%   70.88%   +1.25%     
==========================================
  Files         160      154       -6     
  Lines       15149    14582     -567     
==========================================
- Hits        10549    10337     -212     
+ Misses       4600     4245     -355

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@talboren talboren mentioned this pull request Nov 24, 2024
Closed
@talboren talboren changed the title [WIP] chore: cleaning up the room chore: cleaning up the room Nov 24, 2024
@talboren talboren changed the title chore: cleaning up the room chore: reduce memory consumption and dockerfile size Nov 24, 2024
@Matvey-Kuk Matvey-Kuk self-requested a review November 25, 2024 08:10
@talboren talboren enabled auto-merge (squash) November 25, 2024 08:20
Matvey-Kuk
Matvey-Kuk previously approved these changes Nov 25, 2024
View reviewed changes
@talboren talboren merged commit bdc8e52 into main Nov 25, 2024
12 checks passed
@talboren talboren deleted the feat/clean-up branch November 25, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Matvey-Kuk Matvey-Kuk Matvey-Kuk approved these changes

Assignees
No one assigned
Labels
size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Memory consumption and Docker image file size for backend (API)
2 participants
@talboren @Matvey-Kuk