Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation module: CSIP17 violation isn't detected when dmdSec is missing #156

Open
PhillipAasvangTommerholt opened this issue Jun 26, 2023 · 3 comments
Assignees
Milestone

Comments

@PhillipAasvangTommerholt

Running validation (v 2.3.3) up against https://github.com/DILCISBoard/eark-ip-test-corpus/blob/integration/corpora/csip/metadata/dmdsec/CSIP17/IP_18006_CSIP17_1.zip states that the CSIP17 test is passed.

However, Root METS.xml and Representation METS.xml doesn't have a dmdSec. I believe the validator outcome should be 'failed'.

IP_18006_CSIP17_1.zip_validation-report_2023-06-19_1.json.txt

@PhillipAasvangTommerholt PhillipAasvangTommerholt changed the title CSIP17 violation isn't detected when dmdSec is missing Validation module: CSIP17 violation isn't detected when dmdSec is missing Jun 26, 2023
@AntonioG70
Copy link
Contributor

Hi,

The CSIP17 checks for the presence of mets/dmdSec (descriptive metadata section) whenever a SIP contains descriptive metadata. Since your SIP does not include any descriptive metadata, the dmdSec is not mandatory, and the test should pass successfully.

@AntonioG70 AntonioG70 moved this to Done in E-ARK CSP Jun 27, 2023
@PhillipAasvangTommerholt
Copy link
Author

I read the CSIP17 as: "there SHOULD be descriptive metadata". Therefore I would expect a validator to give a warning if it doesn't exist. However, if there is descriptive metadata content in the package, then it MUST be described in dmdSec - so there are different tests and severity levels located to the same CSIP17 (also described here: #157)
image

@carlosjepard
Copy link
Contributor

Hello Phillip!
I understand you interpretation, but note that the cardinality starts with 0, so that means that if there is no dmdSec the validation should pass as valid (assuming that there are also no descriptive files).

@hmiguim hmiguim added this to the 2.3.4 milestone Aug 4, 2023
@hmiguim hmiguim moved this from In Progress to To Review in E-ARK CSP CORE.3 Validation Framework Aug 4, 2023
@hmiguim hmiguim modified the milestones: 2.4.0, Next Version Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

4 participants