Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packet assembly #3

Open
waywardmonkeys opened this issue Oct 22, 2014 · 13 comments
Open

Packet assembly #3

waywardmonkeys opened this issue Oct 22, 2014 · 13 comments

Comments

@waywardmonkeys
Copy link
Contributor

Have you considered adding the generation of an assemble method (or whatever you want to call it) where you pass in an object and the parser converts it to a buffer?

@keichi
Copy link
Owner

keichi commented Oct 27, 2014

Yes I did think about adding binary serialization feature, however, when I first began implementig this library, just parsing was enough. If there are requests for such feature, I could start working on it.

@keichi
Copy link
Owner

keichi commented Oct 27, 2014

It seems like there are very few modules on npm that is capable of both parsing and generating binary data to/from structured data, so more or less, there should be a demand for that kind of a module.

@waywardmonkeys
Copy link
Contributor Author

deoxxa/dissolve has a partner module deoxxa/concentrate ... https://github.com/bigeasy/packet can do it.

@keichi
Copy link
Owner

keichi commented Oct 27, 2014

Ah, this is exactly what I meant! Personally, that DSL-based API isn't very attractive though. What are your opinions?

@waywardmonkeys
Copy link
Contributor Author

I don't like it much. I suspect most of the right thing can happen with the current syntax of binary-parser. One issue would be for skip, but that's something that can be solved.

@rkovacevic
Copy link

+1 would like to see this

1 similar comment
@TronicLabs
Copy link

+1 would like to see this

@jphgross
Copy link

+1 would like to see this.

@tevaum
Copy link

tevaum commented Feb 1, 2016

+1 from me too :]

@abalmos
Copy link

abalmos commented Feb 22, 2016

👍

@fb55
Copy link

fb55 commented Mar 13, 2016

In case anyone is interested: I started working on this at fb55/binary-serializer.

@ryan-rowland
Copy link

I've gone a different way with this and begun implementing a parallel solution from the ground-up that does both serialization and parsing. https://github.com/ryan-rowland/binary-schema

I'm writing the backlog via GitHub issues if anybody is interested in contributing.

It's already on npm as binary-schema

@emcee-ai
Copy link

PR #73 aims to provide the desired functionality. Care to comment on, or lend support for that PR?

sandiz pushed a commit to psarcjs-forks/binary-parser that referenced this issue Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants