-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packet assembly #3
Comments
Yes I did think about adding binary serialization feature, however, when I first began implementig this library, just parsing was enough. If there are requests for such feature, I could start working on it. |
It seems like there are very few modules on npm that is capable of both parsing and generating binary data to/from structured data, so more or less, there should be a demand for that kind of a module. |
deoxxa/dissolve has a partner module deoxxa/concentrate ... https://github.com/bigeasy/packet can do it. |
Ah, this is exactly what I meant! Personally, that DSL-based API isn't very attractive though. What are your opinions? |
I don't like it much. I suspect most of the right thing can happen with the current syntax of binary-parser. One issue would be for |
+1 would like to see this |
1 similar comment
+1 would like to see this |
+1 would like to see this. |
+1 from me too :] |
👍 |
In case anyone is interested: I started working on this at fb55/binary-serializer. |
I've gone a different way with this and begun implementing a parallel solution from the ground-up that does both serialization and parsing. https://github.com/ryan-rowland/binary-schema I'm writing the backlog via GitHub issues if anybody is interested in contributing. It's already on npm as binary-schema |
PR #73 aims to provide the desired functionality. Care to comment on, or lend support for that PR? |
Have you considered adding the generation of an
assemble
method (or whatever you want to call it) where you pass in an object and the parser converts it to a buffer?The text was updated successfully, but these errors were encountered: