Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test improvements #192

Open
eytan-avisror opened this issue Nov 11, 2020 · 0 comments
Open

Unit test improvements #192

eytan-avisror opened this issue Nov 11, 2020 · 0 comments
Labels
CI/CD eks testing

Comments

@eytan-avisror
Copy link
Collaborator

There are multiple improvements we should make to unit tests:

  • Add more unit tests around validations in instancegroup_types.go
  • Add unit tests around kubernetes provider - currently completely uncovered
  • Add unit tests around common package - currently completely uncovered
  • Check if feasible to also add unit tests around instancegroup_controller.go
@eytan-avisror eytan-avisror changed the title Epic: Unit test improvements Unit test improvements Nov 11, 2020
@eytan-avisror eytan-avisror mentioned this issue Nov 11, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI/CD eks testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eytan-avisror