Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Label: Add label for LaunchConfig on the node #295

Open
eytan-avisror opened this issue May 6, 2021 · 2 comments
Open

Node Label: Add label for LaunchConfig on the node #295

eytan-avisror opened this issue May 6, 2021 · 2 comments

Comments

@eytan-avisror
Copy link
Collaborator

eytan-avisror commented May 6, 2021

We recently added AMI label for nodes, we should also add LaunchConfig label.

This is especially useful for a user to know that for a given instancegroup, all nodes are using a particular launchconfig.

We should also add LaunchConfig as a tag on specific metrics so it can be queries from Prometheus

@eytan-avisror
Copy link
Collaborator Author

eytan-avisror commented May 8, 2021

This is actually not easily doable, especially in the case of launch template version, which we only know when we create the version, which already contains the userdata and the labels.

Getting only the scaling config name would be doable, but in the case of launch template it's not very helpful since you need the version for it to have any value.

Chicken/egg - userdata contains labels, labels need to contain config name/version

@preflightsiren
Copy link
Contributor

looks like ec2 instances have a tag:
aws:ec2launchtemplate:version: 2

which may help with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants