Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check for role attached to instance profile and create if it doe… #372

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix: check for role attached to instance profile and create if it doe… #372

wants to merge 5 commits into from

Conversation

backjo
Copy link
Collaborator

@backjo backjo commented May 23, 2022 •
edited
Loading

Fixes #371

@backjo backjo requested review from a team as code owners May 23, 2022 16:16
@backjo
Add nil check for profile
f994628 
Signed-off-by: Jonah Back <[email protected]>
@codecov
Copy link

codecov bot commented May 24, 2022 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 50.35%. Comparing base (c7b755c) to head (1eefe38).

Files Patch % Lines
controllers/providers/aws/iam.go 0.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #372      +/-   ##
==========================================
- Coverage   50.38%   50.35%   -0.03%     
==========================================
  Files          33       33              
  Lines        5216     5219       +3     
==========================================
  Hits         2628     2628              
- Misses       2439     2442       +3     
  Partials      149      149

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

eytan-avisror
eytan-avisror reviewed Jun 1, 2022
View reviewed changes
controllers/providers/aws/iam.go
@@ -224,10 +229,9 @@ func (w *AwsWorker) CreateScalingGroupRole(name string) (*iam.Role, *iam.Instanc
return createdRole, createdProfile, errors.Wrap(err, "failed to attach instance-profile")
}
}
} else {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an indentation problem from line 226?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eytan-avisror eytan-avisror eytan-avisror approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Instance profile is stuck in bad state if error occurs when initial role is attached
3 participants
@backjo @eytan-avisror @tekenstam